Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception loop in QueueConsumer #776

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Feb 21, 2019

Closes #774

I finally understand how this happened and how it should be done correctly so here is the fix.

The if from #725 is not necessary. It was actually wrong anyway - the condition was always true.

I also sent the same PR to Symfony. symfony/symfony#30327

@makasim makasim merged commit ab32ca9 into php-enqueue:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop when handling an exception (critical bug in my opinion)
2 participants